<html>
<head><meta charset="utf-8"><title>time for a break · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html">time for a break</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="214975619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/214975619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#214975619">(Oct 29 2020 at 14:42)</a>:</h4>
<p>Heya, in the past few weeks and months I haven't been as active as I used to. I think this is mostly due to WFH habits and a lot of other things going on right now. So, instead of dragging along pending reviews, I think it's better if I take myself off of the reviewer list for a while.<br>
I opened a highfive PR here: <a href="https://github.com/rust-lang/highfive/pull/295">https://github.com/rust-lang/highfive/pull/295</a><br>
Stay healthy everyone <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="214983431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/214983431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#214983431">(Oct 29 2020 at 15:31)</a>:</h4>
<p>Can you go through the PRs assigned to you and reassign them please? But keep in mind, that <span class="user-mention" data-user-id="132040">@Manish Goregaokar</span> and I also have some real life stuff going on right now and are struggeling to get our reviews in. <span class="user-mention" data-user-id="279272">@Eduardo Broto</span>  already has 11 PRs assigned to him and tries his best to get through them.  <span class="user-mention" data-user-id="248599">@llogiq</span> hasn't had many PRs assigned to him, since he came back as a reviewer, so he might be happy to get some :)</p>



<a name="214985010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/214985010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#214985010">(Oct 29 2020 at 15:40)</a>:</h4>
<p>I'm also changing jobs at the moment, so I've been a bit more busy lately. Luckily october will end soon...  <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="215080619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/215080619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#215080619">(Oct 30 2020 at 11:10)</a>:</h4>
<p>Yeah, we've got a lot of PRs coming in, compared to the people we have doing reviews. I'm trying to review some of mine and re-assign the rest :)</p>



<a name="215080680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/215080680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#215080680">(Oct 30 2020 at 11:11)</a>:</h4>
<p>I wonder if it would make sense for highfive to have a configurable maximum amout of pending reviews per reviewer to avoid overburdening people?</p>



<a name="215092831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/215092831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#215092831">(Oct 30 2020 at 13:18)</a>:</h4>
<blockquote>
<p>configurable maximum</p>
</blockquote>
<p>Then you end up with prs with no assigned reviewer :/</p>



<a name="215092851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/215092851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#215092851">(Oct 30 2020 at 13:18)</a>:</h4>
<p>At some point you just have more prs than people</p>



<a name="215262270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/215262270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nelson J Morais <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#215262270">(Nov 01 2020 at 21:05)</a>:</h4>
<p>do we have a dashboard with that data?... assigned PRs/unsigned,  sum by reviewers...</p>



<a name="215365184"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/215365184" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#215365184">(Nov 02 2020 at 19:18)</a>:</h4>
<p>Not really a dashboard, but you can use GitHub filters to get these numbers:<br>
Here <a href="https://github.com/pulls?q=is%3Aopen+is%3Apr+assignee%3Aflip1995+archived%3Afalse+">https://github.com/pulls?q=is%3Aopen+is%3Apr+assignee%3Aflip1995+archived%3Afalse+</a> you can filter by assignee over all repos<br>
Or if you're only interested in one repo, you can filter PRs there by Assignee: <a href="https://github.com/rust-lang/rust-clippy/pulls/assigned/flip1995">https://github.com/rust-lang/rust-clippy/pulls/assigned/flip1995</a></p>



<a name="221398621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/time%20for%20a%20break/near/221398621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/time.20for.20a.20break.html#221398621">(Jan 02 2021 at 12:46)</a>:</h4>
<p>Happy to report that taking an actual break is a good idea <span aria-label="joy" class="emoji emoji-1f602" role="img" title="joy">:joy:</span><br>
I opened a PR to re-add myself again: <a href="https://github.com/rust-lang/highfive/pull/303">https://github.com/rust-lang/highfive/pull/303</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>